Misc bugfixes #342
Open
Misc bugfixes #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 857 860 +3
Branches 146 147 +1
=========================================
+ Hits 857 860 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
If extract_addresses() returns an empty list (e.g., malformed From header like "undisclosed-recipients:;"), extract_sender now returns None instead of raising IndexError.
The last_ehlo_response setter parses ESMTP extensions and sets supports_esmtp=True. This was being called before checking if the response code indicated success, so a failed EHLO would still set supports_esmtp=True. Move the assignment after the validation.
The auth_crammd5 method was missing the timeout parameter on the verification command, unlike auth_plain which correctly passes it. This could cause the command to hang indefinitely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.