Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title tags to Dark/Light mode toggle button to let user know what it does when hovering over it #118

Conversation

onnimonni
Copy link
Contributor

@onnimonni onnimonni commented Oct 23, 2023

Changes

Add <title> tags to the Dark/Light mode svg icons so that user will see what the button does when hovering mouse on top of it. We already did have similiar <title> tags on the social link icons so it felt natural to add them to the Dark/Light mode as well.

See example here:
image

Tests

  • Automated tests have been added
  • This PR does not require tests

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for hugo-lotusdocs ready!

Name Link
🔨 Latest commit 55f0a9c
🔍 Latest deploy log https://app.netlify.com/sites/hugo-lotusdocs/deploys/65381c09706aa80007dc2421
😎 Deploy Preview https://deploy-preview-118--hugo-lotusdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@onnimonni
Copy link
Contributor Author

I wasn't sure if I should have used Toggle instead of Enable so feel free to change it. For me enable just sounded better.

@colinwilson
Copy link
Owner

colinwilson commented Oct 24, 2023

Awesome!

I updated the other language translations (de,fr,pt).

I wasn't sure if I should have used Toggle instead of Enable so feel free to change it. For me enable just sounded better.

I agree 'Enable' is the better choice.

Thank you for contributing. 👍

@colinwilson colinwilson added the enhancement New feature or request label Oct 24, 2023
@colinwilson colinwilson self-assigned this Oct 24, 2023
@colinwilson colinwilson merged commit 134f5c3 into colinwilson:release Oct 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants