Max fileupload #411
Merged
Max fileupload #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauritsvanrees
requested changes
Aug 4, 2023
There was a problem hiding this comment.
There are some pdb's in the code. This is why the tests fail. Actually, let me fix that myself. Done and pushed.
Tried on a new site: this works. Initially I get no validation errors, because no limit is set by default. When I set a low number in the registry and upload a file, I get a validation error. With a much higher number, upload works fine. So the basis is good. Thanks!.
On on existing site it fails with an exception:
plone.api.exc.InvalidParameterError: Cannot find a record with name 'easyform.max_filesize'
So this needs migration.
Also, this should be in the easyform control panel.
gotcha
requested changes
Aug 8, 2023
|
added the Changes.rst and also updated locales (with extra dutch translations) |
…continues to work when the form is re-submitted.
added some dutch translations
|
I have released this in 4.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the option to set a max filesize to upload in a form