chore: upgrade to eslint 9.x #625
Conversation
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi there, sorry this slipped through the cracks. Looks like it's now in need of rebasing. Is the change still current? |
|
no worries, this should be caught up now 👍 since we use prettier for all formatting, the pr is a lot simpler now |
|
Thanks! If it wouldn't be too much hassle, would you mind separating the Prettier run from the substantive changes to the config? Currently the commit log will display all of them under the commit "chore: upgrade to eslint 9.x". Fine to just separate into two commits in this PR, then we can just rebase instead of squashing when merging. |
|
should be sorted 👍 |
| @@ -1,3 +1,4 @@ | |||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | |||
There was a problem hiding this comment.
Not a blocker for this PR, but I'd consider removing this ESLint rule so we don't have to do this.
LeaVerou
left a comment
LeaVerou
left a comment
There was a problem hiding this comment.
Thanks again! LGTM but someone who has worked more with types like @MysteryBlokHed should also review this.
Upgrades to ESLint 9 and uses flat config rather than `.eslintrc`.
Runs prettier against `types/` which seemed to have previously been left unformatted.
3 participants
Upgrades ESLint and moves to the new flat config style.
Also fixes up some newly found lint errors/warnings and enables TSESLint's strict config.
I was roaming around the repo so figured I'd do this while I'm in there. if you don't want it, all good just let me know and we can close this 👍
Notes
npm run build:tsfails with a lot of errors. is that known to be broken? (inmain)