Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DictCache, which is unused #51

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

kurtmckee
Copy link
Contributor

This PR introduces the following changes:

  • Remove DictCache, which is unused

This helps prepare for code coverage reporting, which I intend to introduce in a future PR.

@alexprengere
Copy link
Collaborator

I think this "used to be used". We can revert later if someone raises an issue with this.

@alexprengere alexprengere merged commit 878e195 into colour-science:master Sep 24, 2024
10 checks passed
@kurtmckee kurtmckee deleted the rm-DictCache branch September 24, 2024 18:43
@kurtmckee
Copy link
Contributor Author

On this note, it may be that the caching example can be expanded in the docs; the .get()/.set() call contract currently appears to be undocumented, so this may be improved via documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants