Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala 3.3.2 & 3.3.3 #1434

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Scala 3.3.2 & 3.3.3 #1434

merged 2 commits into from
Mar 4, 2024

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Mar 4, 2024 •
edited
Loading

@Gedochao Gedochao marked this pull request as ready for review March 4, 2024 15:22
@Gedochao
Copy link
Contributor Author

Gedochao commented Mar 4, 2024

Seems like the CI is passing, we should be good for 3.3.2 & 3.3.3.
This solves the 3.3.2 part of #1425
cc @lefou

lefou
lefou approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lefou lefou merged commit 50d39ec into com-lihaoyi:main Mar 4, 2024
20 checks passed
@lefou lefou added this to the 3.0.0-M1 milestone Mar 4, 2024
@lefou lefou mentioned this pull request Mar 4, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@Gedochao @lefou