Skip to content

Commit

Permalink
Fix semanticDbData for mill-build (#3673)
Browse files Browse the repository at this point in the history
When we override `scalacPluginClasspath` we need to remeber to also
override `semanticDbPluginClasspath`

Fixes #3666

Pull Request: #3673
  • Loading branch information
lolgab authored Oct 5, 2024
1 parent 5c3380d commit 6c42616
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ object MillPluginClasspathTest extends UtestIntegrationTestSuite {
))
}
}
test("semanticDbData") - integrationTest { tester =>
import tester._
retry(3) {
val res1 = eval(("--meta-level", "1", "semanticDbData"))
assert(res1.isSuccess)
}
}

}
}
3 changes: 3 additions & 0 deletions runner/src/mill/runner/MillBuildRootModule.scala
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,9 @@ abstract class MillBuildRootModule()(implicit
override def scalacPluginClasspath: T[Agg[PathRef]] =
super.scalacPluginClasspath() ++ lineNumberPluginClasspath()

override protected def semanticDbPluginClasspath: T[Agg[PathRef]] =
super.semanticDbPluginClasspath() ++ lineNumberPluginClasspath()

def lineNumberPluginClasspath: T[Agg[PathRef]] = Task {
millProjectModule("mill-runner-linenumbers", repositoriesTask())
}
Expand Down

0 comments on commit 6c42616

Please sign in to comment.