Skip to content

Commit

Permalink
Try and speed up proguard contrib module/tests by re-using global jav…
Browse files Browse the repository at this point in the history
…a runtime jar (#3713)

Proguard is a long pole in the windows contrib test job, hopefully this
makes it a bit faster

Seems to cut a few minutes; previously it ran in 12-17min, with this PR
it ran in 10+ min
  • Loading branch information
lihaoyi authored Oct 10, 2024
1 parent fe6ac67 commit 9a0ffc2
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions contrib/proguard/src/mill/contrib/proguard/Proguard.scala
Original file line number Diff line number Diff line change
Expand Up @@ -65,18 +65,8 @@ trait Proguard extends ScalaModule {
* Keep in sync with [[javaHome]].
*/
def java9RtJar: T[Seq[PathRef]] = Task {
if (mill.main.client.Util.isJava9OrAbove) {
val rt = T.dest / Export.rtJarName
if (!os.exists(rt)) {
T.log.outputStream.println(
s"Preparing Java runtime JAR; this may take a minute or two ..."
)
Export.rtTo(rt.toIO, false)
}
Seq(PathRef(rt))
} else {
Seq()
}
if (mill.main.client.Util.isJava9OrAbove) Seq(PathRef(T.home / Export.rtJarName))
else Seq()
}

/**
Expand Down

0 comments on commit 9a0ffc2

Please sign in to comment.