Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak examples and visualize rendering #2697

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Aug 18, 2023

Makes both a bit prettier in preparation for usage in slides for Scaladays 2023 Madrid

For the SVG visualization, I replaced the oval node shape with rectangular nodes, and make it go from left-to-right with the arrows pointing in the direction of the dataflow. This makes it much easier to read because nodes tend to be more wide than tall, and the graph tends to be more wide than deep, so having sibling nodes stack up vertically ends up being much more compact than having them side-by-side horizontally

@lihaoyi lihaoyi merged commit b5388e1 into com-lihaoyi:main Aug 18, 2023
37 checks passed
@lefou lefou added this to the 0.11.2 milestone Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants