Fixes: #3862; Added an example Python Support case study

[himanshumahajan138]

Pull Request

Added an example Python Support case study
Fixes: #3862

Description

Added Python Support for Mill From basic installation to multiple supports like virtual environment, mypy integration , pex integration

Related Issues

• Link to related issue Add an example Python Support case study (500USD bounty) #3862.

Checklist

• Python-hello example
• Python-modules example
• Python-dependencies example
• Python-mypy support example
• Python-pex Support example
• Documentation Updated

Additional Notes: (Code Copy and Plagiarism is Strictly Prohibited in case of Bounty)

Reminder: Contributions must be original or appropriately attributed. Strict action may be taken by the community for cheating and coping the code from some PR for Bounty or plagiarized code to maintain integrity within the community.

[lihaoyi]

Please clean this up to follow the Typescript example documentation. Your code and documentation is far too verbose, far too repetitive, and generally not sufficiently simplified to be suitable for educational purposes. I cannot fix every detail for you, you need to go and read through those examples yourself and fix your code and documentation to match

[himanshumahajan138]

Ok @lihaoyi sir, Thanks for reviewing

My silly mistake made one test fail its just f string error 😔

No worries i will update the code and documentation

[himanshumahajan138]

@lihaoyi Sir Final Testing has been done...

• Documentation Updated (Written by me 😅)
• Code Logic Updated as per TypeScript Example
• combined moduleDeps, virtualEnv & libraryDeps (coz they are dependent to each other)
• All Tests Passed and Code is checked thrice...

Please pardon me if anything missed or done in wrong way...

[himanshumahajan138]

@lihaoyi Sir Let me tell you one thing that i have seen actually i installed Ubuntu in WSL and when i run it for the first time it just only provides python which is installed with only setuptools and nothing else (no pip , no venv and others )

So when i searched on internet i came to know that we have to install pip and venv using sudo apt install python3-pip and sudo apt install python3-venv

but now here comes the problem of permissions we cant get sudo for every task and even this is not the good practise

so to tackle this problem i have used official guide for installing pip for users without requiring sudo permission and this will be installed for the user rather than the sudo

i think this is a good approach, rest if you say i will follow your way...

[lefou]

A Mill build process should not install anything outside of the project directory, unless it's some kind of cache like coursier. We should just depend on installed tools and provide meaningful error messages if they are missing. We can provide installation/setup support in some external module, e.g. build.PythonModule/installPip, but that should be purely optional.

[himanshumahajan138]

A Mill build process should not install anything outside of the project directory, unless it's some kind of cache like coursier. We should just depend on installed tools and provide meaningful error messages if they are missing. We can provide installation/setup support in some external module, e.g. build.PythonModule/installPip, but that should be purely optional.

But Sir what about github actions tests ?

i think they will fail (not sure)

[himanshumahajan138]

Sir Please see this image i just installed the ubuntu-24.04 version and when i tried these commands you can see that it don't comes with pip and venv

Moreover, i am not downloading anything outside the T.dest actually i just downloaded get-pip.py in T.dest and then using this we installed pip for user originally that's the official way

[lihaoyi]

You should be able to use python3 -m pip and python3 -m venv without needing installation

[himanshumahajan138]

ok then let me recall the updates again:

• no need to install pip and virtualenv
• mypy will be added in first example (5-hello-python) change in compile function
• no need for activating venv
• no need for all sources
• and other minor updates...

Thanks For Review Sir (This community is filled with helpful members❤️)

[lihaoyi]

@himanshumahajan138 yep! I expect this will take multiple rounds of back and forth review to polish into shape, but it's moving in the right direction so I think we'll eventually get there

[himanshumahajan138]

@lihaoyi Sir, Code and Documentation is Updated and Ready for Review...

Please Pardon me if I made any mistake or missed something...

Thanks...

[lihaoyi]

@himanshumahajan138 took a pass, most of the comments apply to all the examples.

Getting pretty close I think, looks a lot better than when we started!

[himanshumahajan138]

@lihaoyi sir, like i have used type checking in every example is that a good and right way

Moreover i will update all of these reviews for every example

[lihaoyi]

Yes having typechecking in every example is right. The examples are meant to build upon each other, so we would expect them to get longer and more complex as it progresses down the list

[himanshumahajan138]

@lihaoyi Sir, finally I have Updated the Code as per reviews and now I think we can move further in review or merging part

Hope you Like it...

Thanks for Reviews Sir...

[lihaoyi]

Rather than using instructions here, we should use sed to uncomment it in the Usage block, and then run ./mill typeCheck again to show the error that is generated

[himanshumahajan138]

actually sir i want to show error also but the problem is that if i write code for error then it will fail in ci test as this will me a major error from mypy side so how can i do this

please Guide me a little Bit Sir...

[lihaoyi]

Took a review pass. Many of the comments apply to the following docs and examples as well

[himanshumahajan138]

@lihaoyi Sir, Ready for Next Reviews

what i changed in last updates:

• updated documentation and some code
• updated scripts and shorten them
• rewrite the documentation
• removed irrelevant and repeative codes and docs

Thanks For Reviews Sir...

[himanshumahajan138]

@lihaoyi Sir is there something wrong with ci tests this unknown type of test case failed (not even related to my code changes) ?

unknowingly, My PR Got ❌ Tag...