Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binds more Vi utilities, and creates tests #25

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

illusionalsagacity
Copy link
Contributor

resolves #20, with the exception of the resetConfig function.

@illusionalsagacity
Copy link
Contributor Author

The CI error seems to be related to vite trying to bundle vitest because it is referenced in Vitest.mjs This doesn't happen in the zero-cost style of bindings, because vitest is compiling the test files differently to the source (rescript output) files.

src/Vitest.res Show resolved Hide resolved
src/Vitest.res Show resolved Hide resolved
src/Vitest.res Show resolved Hide resolved
@illusionalsagacity
Copy link
Contributor Author

@cometkim Any chance you could take a look at this? :)

@cometkim
Copy link
Owner

Oh, sorry. I will look into it in a few hours

@cometkim cometkim merged commit 967a7dd into cometkim:main Aug 22, 2024
2 checks passed
@cometkim
Copy link
Owner

Thank you @illusionalsagacity

After cleaning things up, I'll release a new release.

@illusionalsagacity illusionalsagacity deleted the vi-utilities branch August 22, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unbound vi utility functions
2 participants