Address review

comic · Dec 12, 2024 · 9a08b1b · 9a08b1b
1 parent 1d2ddce
commit 9a08b1b
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/app/grandchallenge/algorithms/forms.py b/app/grandchallenge/algorithms/forms.py
@@ -1409,18 +1409,18 @@ def save(self):
                 algorithm=self._algorithm
             ).update(is_default=False)
 
-        if AlgorithmAlgorithmInterface.objects.filter(
+        matched_rows = AlgorithmAlgorithmInterface.objects.filter(
             algorithm=self._algorithm, interface=interface
-        ).exists():
-            AlgorithmAlgorithmInterface.objects.filter(
-                algorithm=self._algorithm, interface=interface
-            ).update(is_default=self.cleaned_data["set_as_default"])
-        else:
+        ).update(is_default=self.cleaned_data["set_as_default"])
+
+        if matched_rows == 0:
             self._algorithm.interfaces.add(
                 interface,
                 through_defaults={
                     "is_default": self.cleaned_data["set_as_default"]
                 },
             )
+        elif matched_rows > 1:
+            raise RuntimeError("This _really_ shouldn't happen")
 
         return interface