Fix Phase lookups

comic · Jan 9, 2025 · 9ad7117 · 9ad7117
1 parent 7328639
commit 9ad7117
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/app/grandchallenge/evaluation/views/__init__.py b/app/grandchallenge/evaluation/views/__init__.py
@@ -208,8 +208,8 @@ class PhaseUpdate(
     queryset = Phase.objects.prefetch_related("optional_hanging_protocols")
 
     def get_object(self, queryset=None):
-        return Phase.objects.get(
-            challenge=self.request.challenge, slug=self.kwargs["slug"]
+        return get_object_or_404(
+            Phase, challenge=self.request.challenge, slug=self.kwargs["slug"]
         )
 
     def get_form_kwargs(self):
@@ -325,8 +325,8 @@ def get_permission_object(self):
 
     @cached_property
     def phase(self):
-        return Phase.objects.get(
-            challenge=self.request.challenge, slug=self.kwargs["slug"]
+        return get_object_or_404(
+            Phase, challenge=self.request.challenge, slug=self.kwargs["slug"]
         )
 
     def get_form_kwargs(self):
@@ -868,8 +868,8 @@ def form_valid(self, form):
 
     @cached_property
     def phase(self):
-        return Phase.objects.get(
-            slug=self.kwargs["slug"], challenge=self.request.challenge
+        return get_object_or_404(
+            Phase, slug=self.kwargs["slug"], challenge=self.request.challenge
         )
 
     def get_success_url(self):