Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hanging Protocols json field raised exception #3727

Merged
merged 13 commits into from
Dec 12, 2024
Merged

Fix Hanging Protocols json field raised exception #3727

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
55515ea
implement a fix
ammar257ammar Dec 3, 2024
ec4903e
update implementation
ammar257ammar Dec 9, 2024
275bbcf
Add hanging protocol validation test
ammar257ammar Dec 9, 2024
579a9bd
Update hanging protocol json field validation logic
ammar257ammar Dec 10, 2024
b6dca46
Update tests to accomodate json field validation logic change
ammar257ammar Dec 10, 2024
e99361f
Add more test cases
ammar257ammar Dec 10, 2024
c2ac558
Update json input validation
ammar257ammar Dec 10, 2024
92ddcdf
Add more tests
ammar257ammar Dec 10, 2024
8b47cd5
handle more edge cases
ammar257ammar Dec 10, 2024
ce9b716
Add more tests
ammar257ammar Dec 10, 2024
7c51fff
Update implementation
ammar257ammar Dec 12, 2024
0edc735
Update tests
ammar257ammar Dec 12, 2024
1ed471f
clean test implementation
ammar257ammar Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/grandchallenge/hanging_protocols/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ def __init__(self, *args, **kwargs):

def clean_json(self):
json = self.cleaned_data["json"]
viewport_names = [x["viewport_name"] for x in json]
viewport_names = [
x["viewport_name"] for x in json if "viewport_name" in x
ammar257ammar marked this conversation as resolved.
Show resolved Hide resolved
]

self._validate_viewport_uniqueness(viewport_names=viewport_names)
self._validate_dimensions(value=json)
Expand Down
Loading