-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Budget alerts #3747
Budget alerts #3747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just some small comments.
I do have one general question: we're only taking into account compute costs here, not storage costs. I see that this is also what is checked in percent_budget_consumed
and is what is displayed on the cost overview. Yet, with every new submission, we presumably also store a new Docker image, which affects the storage costs. Are the Docker storage costs usually overestimated on the invoice and hence hard to exceed?
Oh I see that James and I looked at this in parallel. Go with James' comments, obviously. ;-) |
Yes it seems like the review tab does not auto update like the comments one. Luckily (or rather unsurprisingly) we gave the same direction! |
We should take into account storage but do not. We have the old problem that the two fields are separate (like how we used to assign budget/submissions per phase). I don't think there is a reason to consider them separately now. There is the problem that the storage costs are an ongoing rate, whereas the compute costs are fixed in time. We don't have per-month tracking of storage costs, I think to really make it work we would need that. |
Co-authored-by: Anne Mickan <amickan1990@gmail.com>
related to https://github.com/DIAGNijmegen/rse-grand-challenge-admin/issues/319