Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid activating an algorithm image if the current active one is used by an evaluation in progress #3785

Conversation

ammar257ammar
Copy link
Contributor

closes #3544

@ammar257ammar ammar257ammar self-assigned this Jan 14, 2025
@amickan
Copy link
Contributor

amickan commented Jan 16, 2025

Thanks for starting to tackle this! After discussing with James, we think there is a more user-friendly approach to fixing the underlying problem. The underlying problem is that we remove non-active images from the registry once a day. Rather than keeping users from developing (i.e. changing the active version of an algorithm or an evaluation), we can just make sure that we don't remove images from the registry if they are still being used.

So that would require adding a check to the periodic task that takes care of removing inactive images: remove_inactive_container_images. We would need to check for active evaluations and jobs and ensure that the linked algorithm images and methods are not added to the list of images to remove.

@ammar257ammar
Copy link
Contributor Author

Does that mean when a new algorithm image is uploaded, it will be activated even if an evaluation is running using the current active one?

@amickan
Copy link
Contributor

amickan commented Jan 16, 2025

Does that mean when a new algorithm image is uploaded, it will be activated even if an evaluation is running using the current active one?

Yes. The activating process does not need to be touched, only the logic about removing inactive images from the registry

@ammar257ammar
Copy link
Contributor Author

ammar257ammar commented Jan 16, 2025

continued in #3788

@jmsmkn jmsmkn deleted the 3544_active_algorithm_image_can_be_changed_with_evaluation_running branch January 20, 2025 10:31
ammar257ammar added a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants