-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmix presentation and content for docpages #3786
Conversation
This reverts commit 9c19ad9. The applied classes cannot be unset from markdown, so the borders and shadows cannot be removed if one would want to.
Images are still an issue. From the markdown syntax page:
We could probably use extensions to tackle images without having to write HTML, but I don't think it's worth the effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Small question and in the new script there are some images that are being used from the production instance. Could you instead create some images on the local instance and use those? They do not have to be the same ones, we have some other jpg/png images in the codebase.
We could probably use extensions to tackle images without having to write HTML, but I don't think it's worth the effort.
Agreed! I think what we do with the class attributes is also good enough.
Will do! |
This adds css for docpages, to enable writing simple markdown focused on content rather then presentation.
For example this removes the need to write
<h3 class="text-center">heading text</h3>
to create a centered heading at the top of the page.
This can now be written simply as
### heading text