Skip to content

Non-functional rate limit toast support #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Non-functional rate limit toast support #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions metron_talker/metron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
from comictalker.comiccacher import ComicCacher
from comictalker.comiccacher import Issue as CCIssue
from comictalker.comiccacher import Series as CCSeries
from comictalker.comictalker import ComicTalker, TalkerNetworkError
from comictalker.comictalker import ComicTalker, RLCallBack, TalkerNetworkError
from mokkari.issue import Issue, IssueSchema, IssuesList
from mokkari.series import AssociatedSeries, Series, SeriesList, SeriesSchema
from urllib3.exceptions import LocationParseError
Expand Down Expand Up @@ -193,6 +193,7 @@ def search_for_series(
refresh_cache: bool = False,
literal: bool = False,
series_match_thresh: int = 90,
on_rate_limit: RLCallBack | None = None,
) -> list[ComicSeries]:
# Sanitize the series name
search_series_name = self._sanitize_title(series_name, literal)
Expand Down Expand Up @@ -233,6 +234,7 @@ def fetch_comic_data(
issue_id: str | None = None,
series_id: str | None = None,
issue_number: str = "",
on_rate_limit: RLCallBack | None = None,
) -> GenericMetadata:
comic_data = GenericMetadata()
if issue_id:
Expand All @@ -242,7 +244,11 @@ def fetch_comic_data(

return comic_data

def fetch_issues_in_series(self, series_id: str) -> list[GenericMetadata]:
def fetch_issues_in_series(
self,
series_id: str,
on_rate_limit: RLCallBack | None = None,
) -> list[GenericMetadata]:
# before we search online, look in our cache, since we might already have this info
cvc = ComicCacher(self.cache_folder, self.version)
cached_series_issues_result = cvc.get_series_issues_info(str(series_id), self.id)
Expand Down Expand Up @@ -290,7 +296,11 @@ def fetch_issues_in_series(self, series_id: str) -> list[GenericMetadata]:
return formatted_series_issues_result

def fetch_issues_by_series_issue_num_and_year(
self, series_id_list: list[str], issue_number: str, year: str | int | None
self,
series_id_list: list[str],
issue_number: str,
year: str | int | None,
on_rate_limit: RLCallBack | None = None,
) -> list[GenericMetadata]:
# At the request of Metron, we will not retrieve the variant covers for matching
issues_result = []
Expand Down Expand Up @@ -417,7 +427,7 @@ def _format_series(self, search_result: Series) -> ComicSeries:

return formatted_result

def fetch_series(self, series_id: int) -> ComicSeries:
def fetch_series(self, series_id: int, on_rate_limit: RLCallBack | None = None) -> ComicSeries:
return self._format_series(self._fetch_series(series_id))

def _fetch_series(self, series_id: int) -> Series:
Expand Down
Loading