Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subaru: driver torque sensor Nm scaling factor and unit #1198

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

martinl
Copy link
Contributor

@martinl martinl commented Aug 29, 2024

This PR adds Nm unit for Subaru driver torque sensor signal for gen1 and gen2 and updates carstate to use new signal. Matched with SSM4 signal output by to jnewb1 at martinl/openpilot#80

@github-actions github-actions bot added DBC signals car related to opendbc/car/ subaru labels Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

Copy link
Collaborator

@jyoung8607 jyoung8607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to have known correct units for the driver input torque signal. However:

  1. You switched to a new signal; it's very important to reference the same signal in Panda safety
  2. Having re-scaled the signal, you also need to re-scale the driver input threshold in openpilot
  3. You will need corresponding scaling and driver input threshold updates to Panda

In short, this is the beginning of a valid change but needs additional work, including a companion Panda PR.

@jyoung8607 jyoung8607 marked this pull request as draft September 6, 2024 15:31
@martinl
Copy link
Contributor Author

martinl commented Sep 6, 2024

Thanks for the comments, I will set up panda safety PR

@martinl
Copy link
Contributor Author

martinl commented Sep 8, 2024

I added the scaling factor and panda PR is at commaai/panda#2016

namestaketoolong added a commit to namestaketoolong/opendbc that referenced this pull request Sep 9, 2024
Subaru: driver torque sensor Nm scaling factor and unit commaai#1198
namestaketoolong added a commit to namestaketoolong/opendbc that referenced this pull request Sep 9, 2024
Subaru: driver torque sensor Nm scaling factor and unit commaai#1198
namestaketoolong added a commit to namestaketoolong/opendbc that referenced this pull request Sep 9, 2024
Subaru: driver torque sensor Nm scaling factor and unit commaai#1198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ DBC signals subaru
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants