DEVX-670: fixing the issue with the tools not being loaded when isAdm #24
Conversation
|
| import {Context, Configuration} from '../types/configuration'; | ||
| import {AvailableNamespaces} from '../types/tools'; | ||
|
|
||
| export const contextToResourceTools = ( |
There was a problem hiding this comment.
I don't understand why we need this 🤔
| types: contextToTypeTools(context), | ||
| 'payment-intents': contextToPaymentIntentTools(context), | ||
| transactions: contextToTransactionTools(context), | ||
| 'business-unit': getToolsForResource( |
There was a problem hiding this comment.
Is there any reason why we are not doing this at the individual contextToTools level?
ajimae
left a comment
ajimae
left a comment
There was a problem hiding this comment.
Hi @ShipilA
I took a look at the PR great work 👍🏽 I left a few comment.
Also, I tested the PR locally and the behaviour is a bit different from what we should have had from this PR and this docs. In summary, when the --tools is all then the --isAdmin must also be true, but that is not the case here.
https://commercetools.atlassian.net/browse/DEVX-670?atlOrigin=eyJpIjoiOGM5MmFmYjljYWYyNDJmNDg2MzM4NmMwYmQzZmJlYzUiLCJwIjoiaiJ9