Make the client using streams the default. Using strings is not susta…

…inable (#359)
commercetools · Oct 7, 2024 · 8df930a · 8df930a
1 parent ec88f07
commit 8df930a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/...cetools.Sdk/IntegrationTests/commercetools.Api.IntegrationTests/ServiceProviderFixture.cs b/...cetools.Sdk/IntegrationTests/commercetools.Api.IntegrationTests/ServiceProviderFixture.cs
@@ -9,7 +9,7 @@
 
 namespace commercetools.Api.IntegrationTests
 {
-    public class ServiceProviderFixture
+    public sealed class ServiceProviderFixture
     {
         private readonly ServiceProvider serviceProvider;
         private readonly IConfiguration configuration;
@@ -26,7 +26,7 @@ public ServiceProviderFixture()
                 AddEnvironmentVariables("CTP_").
                 Build();
 
-            var useStreamClient = Enum.Parse<ClientType>(configuration.GetValue("ClientType", "String")) == ClientType.Stream;
+            var useStreamClient = Enum.Parse<ClientType>(configuration.GetValue("ClientType", "String")) != ClientType.String;
             services.UseCommercetoolsApi(configuration, "Client", options: new ClientOptions { ReadResponseAsStream = useStreamClient });
             services.AddLogging(c => c.AddProvider(new InMemoryLoggerProvider()));
             services.SetupClient(

diff --git a/...Sdk/IntegrationTests/commercetools.GraphQL.Api.IntegrationTests/ServiceProviderFixture.cs b/...Sdk/IntegrationTests/commercetools.GraphQL.Api.IntegrationTests/ServiceProviderFixture.cs
@@ -8,7 +8,7 @@
 
 namespace commercetools.GraphQL.Api.IntegrationTests
 {
-    public class ServiceProviderFixture
+    public sealed class ServiceProviderFixture
     {
         private readonly ServiceProvider serviceProvider;
         private readonly IConfiguration configuration;
@@ -24,7 +24,7 @@ public ServiceProviderFixture()
                 AddUserSecrets<ServiceProviderFixture>().
                 AddEnvironmentVariables("CTP_").
                 Build();
-            var useStreamClient = Enum.Parse<ClientType>(configuration.GetValue("ClientType", "String")) == ClientType.Stream;
+            var useStreamClient = Enum.Parse<ClientType>(configuration.GetValue("ClientType", "String")) != ClientType.String;
 
             services.UseCommercetoolsApi(configuration, "Client", options: new ClientOptions { ReadResponseAsStream = useStreamClient });
             services.AddLogging(c => c.AddProvider(new InMemoryLoggerProvider()));

diff --git a/...s.Sdk/IntegrationTests/commercetools.ImportApi.IntegrationTests/ServiceProviderFixture.cs b/...s.Sdk/IntegrationTests/commercetools.ImportApi.IntegrationTests/ServiceProviderFixture.cs
@@ -6,7 +6,7 @@
 
 namespace commercetools.ImportApi.IntegrationTests
 {
-    public class ServiceProviderFixture
+    public sealed class ServiceProviderFixture
     {
         private readonly ServiceProvider serviceProvider;
         private readonly IConfiguration configuration;
@@ -22,7 +22,7 @@ public ServiceProviderFixture()
                 AddEnvironmentVariables("CTP_").
                 Build();
 
-            var useStreamClient = Enum.Parse<ClientType>(configuration.GetValue("ClientType", "String")) == ClientType.Stream;
+            var useStreamClient = Enum.Parse<ClientType>(configuration.GetValue("ClientType", "String")) != ClientType.String;
             services.UseCommercetoolsImportApi(configuration, "ImportClient", options: new ClientOptions { ReadResponseAsStream = useStreamClient });
             this.serviceProvider = services.BuildServiceProvider();
 

diff --git a/commercetools.Sdk/commercetools.Base.Client/ClientOptions.cs b/commercetools.Sdk/commercetools.Base.Client/ClientOptions.cs
@@ -8,7 +8,7 @@ public class ClientOptions
         public DecompressionMethods DecompressionMethods { get; set; } =
             DecompressionMethods.Deflate | DecompressionMethods.GZip;
 
-        public bool ReadResponseAsStream { get; set; } = false;
+        public bool ReadResponseAsStream { get; set; } = true;
 
         public Version UseHttpVersion { get; set; } = null;
     }