Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to deserialize attribute/custom field numbers as double #515

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

jenschude
Copy link
Contributor

  • Changeset added

Features

Fixes

Breaking changes

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (cf647eb) 10.16% compared to head (b43837e) 10.20%.

❗ Current head b43837e differs from pull request most recent head b42f9e1. Consider uploading reports for the commit b42f9e1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #515      +/-   ##
============================================
+ Coverage     10.16%   10.20%   +0.03%     
- Complexity     1640     1655      +15     
============================================
  Files          5978     5978              
  Lines         56064    56153      +89     
  Branches        239      255      +16     
============================================
+ Hits           5699     5728      +29     
- Misses        50216    50260      +44     
- Partials        149      165      +16     
Files Coverage Δ
...ain/java/com/commercetools/api/json/ApiModule.java 100.00% <100.00%> (ø)
...ava/com/commercetools/docs/meta/Serialization.java 0.00% <ø> (ø)
...rcetools/api/models/product/AttributeAccessor.java 50.45% <50.00%> (+1.85%) ⬆️
...a/com/commercetools/api/json/ApiModuleOptions.java 80.95% <76.92%> (+0.95%) ⬆️
.../commercetools/api/json/AtrributeDeserializer.java 84.61% <37.50%> (-3.68%) ⬇️
...ommercetools/api/json/CustomFieldDeserializer.java 83.63% <37.50%> (-3.87%) ⬇️
...rcetools/api/models/type/CustomFieldsAccessor.java 51.16% <19.04%> (-32.63%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenschude jenschude merged commit 712998b into main Nov 7, 2023
7 checks passed
@jenschude jenschude deleted the attribute-number-as-double branch November 7, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant