feat(payments): fix converting result bug

commercetools · Mar 11, 2024 · e3a312b · e3a312b
1 parent 1a2cdc7
commit e3a312b
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 15 deletions.
diff --git a/processor/package.json b/processor/package.json
@@ -1,6 +1,6 @@
 {
   "name": "payment-integration-adyen",
-  "version": "0.0.5",
+  "version": "1.0.1",
   "description": "Payment integration with Adyen",
   "main": "dist/server.js",
   "scripts": {

diff --git a/processor/src/services/adyen-payment.service.ts b/processor/src/services/adyen-payment.service.ts
@@ -247,7 +247,10 @@ export class AdyenPaymentService extends AbstractPaymentService {
         type: 'Authorization', //TODO: review
         amount: ctPayment.amountPlanned,
         interactionId: res.pspReference,
-        state: this.convertAdyenResultCode(res.resultCode as PaymentResponse.ResultCodeEnum),
+        state: this.convertAdyenResultCode(
+          res.resultCode as PaymentResponse.ResultCodeEnum,
+          this.isActionRequired(res),
+        ),
       },
     });
 
@@ -281,7 +284,7 @@ export class AdyenPaymentService extends AbstractPaymentService {
         type: 'Authorization',
         amount: ctPayment.amountPlanned,
         interactionId: res.pspReference,
-        state: this.convertAdyenResultCode(res.resultCode as PaymentResponse.ResultCodeEnum),
+        state: this.convertAdyenResultCode(res.resultCode as PaymentResponse.ResultCodeEnum, false),
       },
     });
     return {
@@ -335,18 +338,23 @@ export class AdyenPaymentService extends AbstractPaymentService {
     }
   }
 
-  private convertAdyenResultCode(resultCode: PaymentResponse.ResultCodeEnum): string {
-    switch (resultCode) {
-      case PaymentResponse.ResultCodeEnum.Authorised:
-        return 'Success';
-      case PaymentResponse.ResultCodeEnum.Pending:
-        return 'Pending';
-      case PaymentResponse.ResultCodeEnum.Refused:
-      case PaymentResponse.ResultCodeEnum.Error:
-      case PaymentResponse.ResultCodeEnum.Cancelled:
-        return 'Failure';
-      default:
-        return 'Initial';
+  private convertAdyenResultCode(resultCode: PaymentResponse.ResultCodeEnum, isActionRequired: boolean): string {
+    if (resultCode === PaymentResponse.ResultCodeEnum.Authorised) {
+      return 'Success';
+    } else if (resultCode === PaymentResponse.ResultCodeEnum.Pending && !isActionRequired) {
+      return 'Pending';
+    } else if (
+      resultCode === PaymentResponse.ResultCodeEnum.Refused ||
+      resultCode === PaymentResponse.ResultCodeEnum.Error ||
+      resultCode === PaymentResponse.ResultCodeEnum.Cancelled
+    ) {
+      return 'Failure';
+    } else {
+      return 'Initial';
     }
   }
+
+  private isActionRequired(data: PaymentResponse): boolean {
+    return data.action?.type !== undefined;
+  }
 }