Skip to content

[Breaking] refactor(application-shell): remove support for trackingEventWhitelist #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

adnasa
Copy link
Contributor

@adnasa adnasa commented Oct 5, 2020

Summary

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2020

🦋 Changeset detected

Latest commit: 026cf15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@commercetools-frontend/application-shell Major
merchant-center-application-template-starter Patch
playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/bmp1ma6mr
✅ Preview: https://merchant-center-application-git-adnasa-remove-deprecated-befa2b.commercetools.vercel.app

@adnasa adnasa requested a review from emmenko October 5, 2020 11:28
@emmenko
Copy link
Member

emmenko commented Oct 5, 2020

All breaking changes planned for v17 should be merged into the branch v17. Can you change the target branch?

@adnasa adnasa mentioned this pull request Oct 5, 2020
7 tasks
@adnasa adnasa changed the base branch from master to v17 October 5, 2020 12:56
@emmenko emmenko changed the title refactor(application-shell): remove support for trackingEventWhitelist [Breaking] refactor(application-shell): remove support for trackingEventWhitelist Oct 5, 2020
@tdeekens
Copy link
Contributor

tdeekens commented Oct 5, 2020

Nice so the a release base branch for v17 :)

@adnasa adnasa added 🚀 Status: ship it Triggers an merge if rules match via bot and removed 🚀 Status: ship it Triggers an merge if rules match via bot labels Oct 5, 2020
@adnasa adnasa merged commit d572ff4 into v17 Oct 5, 2020
@adnasa adnasa deleted the adnasa-remove-deprecated-option branch October 5, 2020 15:44
emmenko pushed a commit that referenced this pull request Oct 6, 2020
…ventWhitelist` (#1780)

* refactor(application-shell): remove support for `trackingEventWhitelist`

* chore(changeset): a breaking change note
emmenko pushed a commit that referenced this pull request Oct 7, 2020
…ventWhitelist` (#1780)

* refactor(application-shell): remove support for `trackingEventWhitelist`

* chore(changeset): a breaking change note
emmenko pushed a commit that referenced this pull request Oct 8, 2020
…ventWhitelist` (#1780)

* refactor(application-shell): remove support for `trackingEventWhitelist`

* chore(changeset): a breaking change note
emmenko pushed a commit that referenced this pull request Oct 13, 2020
…ventWhitelist` (#1780)

* refactor(application-shell): remove support for `trackingEventWhitelist`

* chore(changeset): a breaking change note
emmenko pushed a commit that referenced this pull request Oct 13, 2020
…ventWhitelist` (#1780)

* refactor(application-shell): remove support for `trackingEventWhitelist`

* chore(changeset): a breaking change note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants