Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: finish documenting migration steps for v17 #1800

Merged
merged 2 commits into from
Oct 13, 2020
Merged

docs: finish documenting migration steps for v17 #1800

merged 2 commits into from
Oct 13, 2020

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Oct 12, 2020

Ref #1769

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2020 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0d2fc21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 12, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/awal6o4iz
✅ Preview: https://merchant-center-application-kit-git-nm-document-migration-v17.commercetools.vercel.app

@emmenko emmenko force-pushed the nm-document-migration-v17 branch from 900fedd to cff7916 Compare October 12, 2020 09:43
@vercel vercel bot temporarily deployed to Preview October 12, 2020 09:43 Inactive
tdeekens
tdeekens reviewed Oct 12, 2020
View reviewed changes
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks for writing it up!

website/src/releases/2020-10/release-v17.mdx Outdated Show resolved Hide resolved
website/src/releases/2020-10/release-v17.mdx Outdated Show resolved Hide resolved
website/src/releases/2020-10/release-v17.mdx Outdated Show resolved Hide resolved
website/src/releases/2020-10/release-v17.mdx

The `@commercetools-frontend/mc-http-server` package has been deprecated and won't be published anymore.

With the usage of the `compile-html` command there is no need to have a pre-configured HTTP server anymore. If you are using this package, we recommend to use any other HTTP server package to serve your static files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can recommend one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean like express?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 I don't mind. Express or serve or any package. We don't have to was just a thought.

website/src/releases/2020-10/release-v17.mdx Outdated Show resolved Hide resolved
website/src/releases/2020-10/release-v17.mdx Outdated Show resolved Hide resolved
website/src/releases/2020-10/release-v17.mdx Show resolved Hide resolved
website/src/releases/2020-10/release-v17.mdx Outdated Show resolved Hide resolved
website/src/releases/2020-10/release-v17.mdx Outdated Show resolved Hide resolved
@emmenko @tdeekens
docs: improve wording
0d2fc21 
Co-authored-by: Tobias Deekens <tobias.deekens@commercetools.com>
@vercel vercel bot temporarily deployed to Preview October 12, 2020 11:05 Inactive
@adnasa
Copy link
Contributor

adnasa commented Oct 12, 2020

this is nice. good job pushing things forward ! 🙌🏽

@emmenko
Copy link
Member Author

emmenko commented Oct 13, 2020

@tdeekens anything else from your side?

@adnasa
Copy link
Contributor

adnasa commented Oct 13, 2020

what about changeset?

tdeekens
tdeekens approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Thanks for applying my suggested changes.

@emmenko emmenko merged commit 3ce2443 into v17 Oct 13, 2020
@emmenko emmenko deleted the nm-document-migration-v17 branch October 13, 2020 14:26
emmenko added a commit that referenced this pull request Oct 13, 2020
@emmenko @tdeekens
docs: finish documenting migration steps for v17 (#1800)
e107468 
* docs: finish documenting migration steps for v17

* docs: improve wording

Co-authored-by: Tobias Deekens <tobias.deekens@commercetools.com>

Co-authored-by: Tobias Deekens <tobias.deekens@commercetools.com>
emmenko added a commit that referenced this pull request Oct 13, 2020
@emmenko @tdeekens
docs: finish documenting migration steps for v17 (#1800)
06c5631 
* docs: finish documenting migration steps for v17

* docs: improve wording

Co-authored-by: Tobias Deekens <tobias.deekens@commercetools.com>

Co-authored-by: Tobias Deekens <tobias.deekens@commercetools.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnasa adnasa adnasa approved these changes

@tdeekens tdeekens tdeekens approved these changes

@anilkk anilkk anilkk approved these changes

@jonnybel jonnybel Awaiting requested review from jonnybel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emmenko @adnasa @anilkk @tdeekens