CRAFT-2074-eslint v9 migration [new pkgs] #3931
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f06f485 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
 Failed |
Vulnerabilities | 2 4 0 0 |
View in Orca |
☢️ The following Vulnerabilities (CVEs) have been detected
| PACKAGE | FILE | CVE ID | INSTALLED VERSION | FIXED VERSION | ||
|---|---|---|---|---|---|---|
|
diff | ./pnpm-lock.yaml | CVE-2026-24001 | 5.2.0 | 8.0.3, 5.2.2, 4.0.4 | View in code |
|
glob | ./pnpm-lock.yaml | CVE-2025-64756 | 10.4.5 | 11.1.0, 10.5.0 | View in code |
|
node-forge | ./pnpm-lock.yaml | CVE-2025-12816 | 1.3.1 | 1.3.2 | View in code |
|
node-forge | ./pnpm-lock.yaml | CVE-2025-66031 | 1.3.1 | 1.3.2 | View in code |
|
tar | ./pnpm-lock.yaml | CVE-2026-23745 | 6.2.1 | 7.5.3 | View in code |
|
tar | ./pnpm-lock.yaml | CVE-2026-23950 | 6.2.1 | 7.5.4 | View in code |
|
tar | ./pnpm-lock.yaml | CVE-2026-24842 | 6.2.1 | 7.5.7 | View in code |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3931 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 263 263
Lines 6793 6793
Branches 2074 2102 +28
=======================================
Hits 4890 4890
Misses 1882 1882
Partials 21 21
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
valoriecarli
changed the title
…s, fix rule names in config
… function for schema typess
…n 9.x and 8.x respectively, update related dependencies
valoriecarli
force-pushed
the
CRAFT-2074-eslint-v9-migration-new-pkg
branch
from
77fd37e to
4074a31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated experimental branch, original here
Currently under test with commercetools/ui-kit#3216
ESLint 9's flat config format is fundamentally incompatible with ESLint 8's .eslintrc format as they use different structures (array of config objects vs. single object with extends/overrides). While backwards compatibility is technically possible, it would require maintaining two parallel config structures indefinitely.
By creating separate packages, we freeze the legacy package in maintenance mode (security fixes only) while all active development happens in the new
-flatpackages. This approach trades a one-time consumer migration cost for ongoing maintainer simplicity, eliminates version detection risks & provides a clean path to eventually sunset ESLint 8 support by removing the deprecated packages entirely.This PR contains the following:
1.) New packages
@commercetools-frontend/eslint-config-mc-app-flat@commercetools-backend/eslint-config-node-flat2.) Workspace migration to the flat config format, consolidating the linting logic into a single
eslint.config.js:@commercetools-frontend/eslint-config-mc-app-flatdist/,build/), localization files (_translations/), and internal caches (.cache/)3.) To ensure compatibility with the flat config system and ESLint 9, the following modifications were implemented:
TS-ESLintv8 - Required for ESLint 9 supporteslint-plugin-jestv28 - Updated for compatibilityglobalsv15.15.0 - Necessary for explicit global definitions in the flat formatReact/JSXplugins and ruleseslint-plugin-testing-libraryto v6Cypressplugin and browser globalseslint-plugin-nfor Node.js specific linting4.) Legacy package deprecation
@commercetools-frontend/eslint-config-mc-app&@commercetools-backend/eslint-config-nodepackage.jsonpointing users toward the new-flatalternativesindex.js5.) Misc (appkit):
Consumer impact
-flatpackages required when upgrading to ESLint 9