Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields-and-cases #7502

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add fields-and-cases #7502

merged 1 commit into from
Aug 26, 2024

Conversation

m-bock
Copy link
Contributor

@m-bock m-bock commented Aug 12, 2024

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (recommended) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@juhp
Copy link
Contributor

juhp commented Aug 16, 2024

base-4.19.1.0 (changelog) is out of bounds for:

lima (not present) depended on by:


Do please verify the package can build before submitting it :-)

@m-bock
Copy link
Contributor Author

m-bock commented Aug 16, 2024

@juhp sorry, it's the first package that I am adding. Now I fixed the dependencies and run the stack build locally. Everythin works now. I published version 0.2.0.0 of the library which contains the changes.

What's the next step. Would you re-run CI?

@juhp
Copy link
Contributor

juhp commented Aug 17, 2024

No worries, it's okay and thanks

You will need to add lima too since it is not in Stackage Nightly, assuming it's still needed. If it's yours you can just do that, otherwise it's polite to inform or ask the maintainer.

@m-bock
Copy link
Contributor Author

m-bock commented Aug 17, 2024

Alright, good to know. For now I removed lima, since it was not that critical. If I need it in the future, I'll do what you suggest.

@DanBurton DanBurton merged commit 1a0df80 into commercialhaskell:master Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants