test: rename the fixture config to mock_config for better code search #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
requested review from
woile,
Lee-W and
noirbizarre
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-9-2 #1619 +/- ##
=========================================
Coverage ? 98.32%
=========================================
Files ? 58
Lines ? 2684
Branches ? 0
=========================================
Hits ? 2639
Misses ? 45
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lee-W
reviewed
Sep 21, 2025
|
|
||
| @pytest.fixture() | ||
| def config(): | ||
| def mock_config(): |
There was a problem hiding this comment.
We're not mocking a config here. We're providing a sample config instead. mock_config is inaccurate. I probably would try sample_config or something similiar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are too many things called
configin this repo (we have module, parameter key, etc).Added a prefix
mock_so we can distinguish them more easily.