Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong test failure assumption #51

Closed
Tracked by #54
michael-kotliar opened this issue Oct 13, 2020 · 2 comments · Fixed by #59
Closed
Tracked by #54

Wrong test failure assumption #51

michael-kotliar opened this issue Oct 13, 2020 · 2 comments · Fixed by #59

Comments

@michael-kotliar
Copy link

The following two tests fail not because of the specified in the test case reason, but because workflows cannot be parsed due to outputEval: "time passed" line

- job: tests/empty.json

- job: tests/empty.json

@michael-kotliar
Copy link
Author

@tetron @mr-c

@mr-c
Copy link
Member

mr-c commented Oct 31, 2020

Good catch @michael-kotliar !

Here is a suggested fix:

diff --git a/tests/timelimit-wf.cwl b/tests/timelimit-wf.cwl
index bd43ccc..168c10f 100644
--- a/tests/timelimit-wf.cwl
+++ b/tests/timelimit-wf.cwl
@@ -30,5 +30,4 @@ steps:
         o:
           type: string?
           outputBinding:
-            outputEval: "time passed"
-      
+            outputEval: $(runtime.outdir)
diff --git a/tests/timelimit4-wf.cwl b/tests/timelimit4-wf.cwl
index f7d1054..a03fa9d 100644
--- a/tests/timelimit4-wf.cwl
+++ b/tests/timelimit4-wf.cwl
@@ -33,4 +33,4 @@ steps:
         o:
           type: string?
           outputBinding:
-            outputEval: "time passed"
+            outputEval: $("time passed")

As per #54 would you like to make a PR against https://github.com/common-workflow-language/cwl-v1.2/tree/1.2.1_proposed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants