-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong test failure assumption #51
Comments
70 tasks
Good catch @michael-kotliar ! Here is a suggested fix: diff --git a/tests/timelimit-wf.cwl b/tests/timelimit-wf.cwl
index bd43ccc..168c10f 100644
--- a/tests/timelimit-wf.cwl
+++ b/tests/timelimit-wf.cwl
@@ -30,5 +30,4 @@ steps:
o:
type: string?
outputBinding:
- outputEval: "time passed"
-
+ outputEval: $(runtime.outdir)
diff --git a/tests/timelimit4-wf.cwl b/tests/timelimit4-wf.cwl
index f7d1054..a03fa9d 100644
--- a/tests/timelimit4-wf.cwl
+++ b/tests/timelimit4-wf.cwl
@@ -33,4 +33,4 @@ steps:
o:
type: string?
outputBinding:
- outputEval: "time passed"
+ outputEval: $("time passed") As per #54 would you like to make a PR against https://github.com/common-workflow-language/cwl-v1.2/tree/1.2.1_proposed ? |
pvanheus
added a commit
to pvanheus/cwl-v1.2
that referenced
this issue
Nov 10, 2020
mr-c
pushed a commit
that referenced
this issue
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following two tests fail not because of the specified in the test case reason, but because workflows cannot be parsed due to
outputEval: "time passed"
linecwl-v1.2/conformance_tests.yaml
Line 2850 in 993e407
cwl-v1.2/conformance_tests.yaml
Line 2876 in 993e407
The text was updated successfully, but these errors were encountered: