Fix broken test workflows re: issue #51 #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
previously approved these changes
Nov 10, 2020
mr-c
reviewed
Nov 10, 2020
tests/timelimit4-wf.cwl
Outdated
| @@ -33,4 +33,4 @@ steps: | |||
| o: | |||
| type: string? | |||
| outputBinding: | |||
| outputEval: "time passed" | |||
| outputEval: $(runtime.outdir) | |||
There was a problem hiding this comment.
This workflow does have InlineJavascriptRequirement, so this should work, yes?
Suggested change
| outputEval: $(runtime.outdir) | |
| outputEval: $("time passed") |
There was a problem hiding this comment.
ok, I switched to that.
mr-c
approved these changes
Nov 10, 2020
|
Thank you @pvanheus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #51 the two workflows used in the
timelimit_from_expression_wfandtimelimit_basic_wftests have syntax errors. This PR fixes #51