Skip to content

Commit

Permalink
software dependencies: allow newer versions of galaxy-tool-util
Browse files Browse the repository at this point in the history
Skip the known broken versions (23.0.1 - 23.0.5)
  • Loading branch information
mr-c committed Oct 24, 2023
1 parent 3d61ffb commit 4337bee
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 7 deletions.
5 changes: 3 additions & 2 deletions cwltool/software_requirements.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import string
from typing import (
TYPE_CHECKING,
Any,
Dict,
List,
MutableMapping,
Expand Down Expand Up @@ -109,7 +110,7 @@ def build_job_script(self, builder: "Builder", command: List[str]) -> str:

def get_dependencies(builder: HasReqsHints) -> ToolRequirements:
(software_requirement, _) = builder.get_requirement("SoftwareRequirement")
dependencies: List["ToolRequirement"] = []
dependencies: List[Union["ToolRequirement", Dict[str, Any]]] = []
if software_requirement and software_requirement.get("packages"):
packages = cast(
MutableSequence[MutableMapping[str, Union[str, MutableSequence[str]]]],
Expand Down Expand Up @@ -158,7 +159,7 @@ def get_container_from_software_requirements(
[DOCKER_CONTAINER_TYPE], tool_info
)
if container_description:
return cast(Optional[str], container_description.identifier)
return container_description.identifier

return None

Expand Down
2 changes: 2 additions & 0 deletions mypy-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@ types-requests
types-setuptools
types-psutil
types-mock
galaxy-tool-util>=22.1.2,<23.2,!=23.0.1,!=23.0.2,!=23.0.3,!=23.0.4,!=23.0.5
galaxy-util<23.2
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ requires = [
"importlib_resources>=1.4", # equivalent to Python 3.9
"ruamel.yaml>=0.16.0,<0.18",
"schema-salad>=8.4.20230426093816,<9",
"packaging<22",
"cwl-utils>=0.19",
"galaxy-tool-util>=22.1.2,<23.2,!=23.0.1,!=23.0.2,!=23.0.3,!=23.0.4,!=23.0.5",
"toml",
"argcomplete>=1.12.0",
]
Expand Down
5 changes: 4 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,10 @@
"cwl-utils >= 0.22",
],
extras_require={
"deps": ["galaxy-tool-util >= 22.1.2, <23", "galaxy-util <23"],
"deps": [
"galaxy-tool-util>=22.1.2,<23.2,!=23.0.1,!=23.0.2,!=23.0.3,!=23.0.4,!=23.0.5",
"galaxy-util <23.2",
],
},
python_requires=">=3.8, <4",
use_scm_version=True,
Expand Down
4 changes: 2 additions & 2 deletions test-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ pytest-mock>=1.10.0
pytest-cov
arcp>=0.2.0
-rrequirements.txt
galaxy-tool-util>=22.1.2,<23
galaxy-util<23
galaxy-tool-util>=22.1.2,<23.2,!=23.0.1,!=23.0.2,!=23.0.3,!=23.0.4,!=23.0.5
galaxy-util<23.2
2 changes: 1 addition & 1 deletion tests/test_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

deps: Optional[ModuleType] = None
try:
from galaxy.tool_util import deps # type: ignore[no-redef]
from galaxy.tool_util import deps
except ImportError:
pass

Expand Down

0 comments on commit 4337bee

Please sign in to comment.