Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message about other implementations #1683

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tetron
Copy link
Member

@tetron tetron commented Jun 22, 2022

This was merged by accident and reverted, bringing it back for discussion

  • Text might be too "market-y" so looking for suggestions on toning it down
  • After seeing it a few times people might find it tiresome so looking for suggestions on how to turn it off

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1683 (711d18c) into main (b21b0c1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1683      +/-   ##
==========================================
+ Coverage   66.85%   66.88%   +0.03%     
==========================================
  Files          93       93              
  Lines       16648    16664      +16     
  Branches     4420     4422       +2     
==========================================
+ Hits        11130    11146      +16     
  Misses       4376     4376              
  Partials     1142     1142              
Impacted Files Coverage Δ
cwltool/executors.py 83.18% <100.00%> (+0.60%) ⬆️
cwltool/cwltool/executors.py 65.08% <0.00%> (+0.35%) ⬆️
cwltool/job.py 80.27% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21b0c1...711d18c. Read the comment docs.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a comment in the README and --help output would be the better place. Otherwise this reads too much like an advertisement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants