Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load schemas before calling print_deps #1766

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kinow
Copy link
Member

@kinow kinow commented Nov 18, 2022

Closes #1765

Unit test fails for main, and passes on this branch. The command from the issue reported also passes on this branch.

Cheers,
-Bruno

@kinow kinow force-pushed the load-schemas-before-print_deps branch 2 times, most recently from be418e9 to 9792f84 Compare November 18, 2022 23:28
@kinow kinow force-pushed the load-schemas-before-print_deps branch from 9792f84 to 2e5cc2e Compare November 18, 2022 23:36
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #1766 (2e5cc2e) into main (67a1808) will decrease coverage by 28.41%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #1766       +/-   ##
===========================================
- Coverage   82.48%   54.06%   -28.42%     
===========================================
  Files          47       47               
  Lines        8181     8173        -8     
  Branches     2232     2074      -158     
===========================================
- Hits         6748     4419     -2329     
- Misses        939     3218     +2279     
- Partials      494      536       +42     
Impacted Files Coverage Δ
cwltool/main.py 32.09% <0.00%> (-43.37%) ⬇️
cwltool/__main__.py 0.00% <0.00%> (-100.00%) ⬇️
cwltool/factory.py 0.00% <0.00%> (-90.91%) ⬇️
cwltool/pack.py 8.50% <0.00%> (-79.50%) ⬇️
cwltool/cwlviewer.py 22.82% <0.00%> (-76.09%) ⬇️
cwltool/subgraph.py 11.60% <0.00%> (-68.51%) ⬇️
cwltool/provenance.py 14.07% <0.00%> (-67.00%) ⬇️
cwltool/provenance_profile.py 11.01% <0.00%> (-62.79%) ⬇️
cwltool/cuda.py 21.87% <0.00%> (-53.13%) ⬇️
cwltool/software_requirements.py 25.64% <0.00%> (-47.44%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kinow
Copy link
Member Author

kinow commented Nov 19, 2022

Hmmm, curious. I saw the tests failing, they are on the same test file that I used.

I picked the first test that failed for me, test_examples.py, test_trick_scandeps. I can confirm the command tested works on main, and fails on my branch.

However, cwltool --validate $file fails on both main and on this branch. So should a CWL file that fails validation, still be used on a unit test? The file is https://github.com/common-workflow-language/cwltool/blob/67a180835c001906cff4086963cd00ee99893498/tests/wf/trick_defaults.cwl

If so I will dig into the issue more and try to extract the part that loads the schemas from the resolve_and_validate_document function 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cwltool --print-deps fails with workflows having namespaced location steps
1 participant