Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for users with an empty fullname #1771

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Workaround for users with an empty fullname #1771

wants to merge 1 commit into from

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Dec 2, 2022

May fix part of #1770

  • add test with mock to confirm this behavior

@mr-c
Copy link
Member Author

mr-c commented Dec 2, 2022

@sdruskat can you give me the output of python3 -c "import getpass; print(getpass.getuser()); import os; import pwd; print(pwd.getpwuid(os.getuid())[4])" on your WSL2 system? I'll use that to improve the test

@sdruskat
Copy link

sdruskat commented Dec 2, 2022

python3 -c "import getpass; print(getpass.getuser()); import os; import pwd; print(pwd.getpwuid(os.getuid())[4])"

stephan
,,,

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #1771 (7775a7d) into main (60f0dac) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1771      +/-   ##
==========================================
- Coverage   82.47%   82.47%   -0.01%     
==========================================
  Files          47       47              
  Lines        8195     8198       +3     
  Branches     2235     2236       +1     
==========================================
+ Hits         6759     6761       +2     
- Misses        941      942       +1     
  Partials      495      495              
Impacted Files Coverage Δ
cwltool/provenance.py 80.76% <33.33%> (-0.31%) ⬇️
cwltool/singularity.py 65.80% <0.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants