-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump prov to 2.0.1 #2005
base: main
Are you sure you want to change the base?
bump prov to 2.0.1 #2005
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
- Coverage 83.84% 82.90% -0.94%
==========================================
Files 46 46
Lines 8246 8244 -2
Branches 2190 2190
==========================================
- Hits 6914 6835 -79
- Misses 855 904 +49
- Partials 477 505 +28 ☔ View full report in Codecov by Sentry. |
|
Thank you @jfennick , can you fix the test errors? |
ac7b05e
to
74ea21b
Compare
main_run, | ||
PROV.wasAssociatedWith, | ||
engine, | ||
) in g, "Wf run not associated with wf engine" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to be removed? Maybe do a side-by-side diff of running cwltool --provenance some_folder tests/wf/sec-wf-out.cwl
with this PR and without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The short answer is that I couldn't get the CI to pass without removing it. Yes, I tried doing side by side diffs and/or other ways of debugging it, but I'm all out of energy. I don't think I'm going to be able to fix this particular assertion.
I suspect the change is due to one of the following two commits from the prov repo, but IDK.
trungdong/prov@a8aba63
trungdong/prov@2e19dcc
Bump the version of the
prov
library for compatibility with the following PR:trungdong/prov#158