forked from mysociety/local-intelligence-hub
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multitudes: multiple views, marker layers + area explorer displays per data source #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor-maplayer-config
joaquimds
requested changes
Jan 28, 2025
} | ||
}, [mapBounds, mapView.mapOptions, activeTileset]) | ||
|
||
// useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: remove this commented out code
<div className="absolute bottom-12 right-0 z-10 p-4"> | ||
<LoadingIcon size={'50'} /> | ||
</div> | ||
)} */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why is this commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganises the storage and management of report configuration, to facilitate future roadmap items. It also introduces a few early features based on that refactor.
Closes MAP-935, MAP-923, MAP-911, MAP-931, MAP-817
New features
Technical changes
layer
DB field and intodisplayOptions
on a per-view basis. This is so that frontend view changes no longer require changes to the GraphQL type system or other backend work. The logic going forwards can be that we only adjust GraphQL types where other backend logic (e.g. data querying) needs to happen anyway.Testing
Open a map report and the config should auto-migrate to the new schema. Everything should work as expected. For each layer in the report:
And everything should be configurable.