Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printer responsible for Issued Date (DRAFT - DO NOT MERGE). #190

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kristerbone
Copy link
Contributor

@kristerbone kristerbone commented Mar 13, 2023

This PR is DRAFT and for review with EIP and Print Provider.

The issued date needs to be when the certificate is actually printed, therefore the print provider needs to supply the actual date of printing / issued date.

Where the certificate is a re-print, EROP needs to supply the original issuedDate as previously supplied by the printer.

@vishalgupta-valtech vishalgupta-valtech added the x DO-NOT-MERGE x x DO-NOT-MERGE x label Mar 17, 2023
@vishalgupta-valtech
Copy link
Contributor

Added temporary label to not merge, please remove the label once PR is ready/approved to be merged

Copy link
Contributor

@NathanRussellValtech NathanRussellValtech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the version number of the spec files - we update the version for any and all changes to our specs (no matter how small)

In addition. these print provider yml specs are a little different in this respect. Whilst there are several different files (more than the 2 you're updating here), they are all considered "holistically" as one spec. Each file contains a version number, and its the same version number. So you'll want to bump the spec version number in all yml files that make up this spec (4 yml files); plus the README in the same folder contains the version number complete with a change history table.

@vishalgupta-valtech
Copy link
Contributor

This is a month old PR so closing this @kristerbone

@kristerbone kristerbone reopened this May 4, 2023
@kristerbone kristerbone changed the base branch from main to eip-main May 9, 2023 21:59
@StephenPenney StephenPenney changed the base branch from eip-main to main February 16, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x DO-NOT-MERGE x x DO-NOT-MERGE x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants