-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Printer responsible for Issued Date (DRAFT - DO NOT MERGE). #190
base: main
Are you sure you want to change the base?
Conversation
Added temporary label to not merge, please remove the label once PR is ready/approved to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update the version number of the spec files - we update the version for any and all changes to our specs (no matter how small)
In addition. these print provider yml specs are a little different in this respect. Whilst there are several different files (more than the 2 you're updating here), they are all considered "holistically" as one spec. Each file contains a version number, and its the same version number. So you'll want to bump the spec version number in all yml files that make up this spec (4 yml files); plus the README
in the same folder contains the version number complete with a change history table.
This is a month old PR so closing this @kristerbone |
This PR is DRAFT and for review with EIP and Print Provider.
The issued date needs to be when the certificate is actually printed, therefore the print provider needs to supply the actual date of printing / issued date.
Where the certificate is a re-print, EROP needs to supply the original issuedDate as previously supplied by the printer.