Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EROPSPT-390: Add endpoint for VAC photos #320

Merged
merged 5 commits into from
Nov 15, 2024
Merged

EROPSPT-390: Add endpoint for VAC photos #320

merged 5 commits into from
Nov 15, 2024

Conversation

kirstenland
Copy link
Contributor

@kirstenland kirstenland commented Nov 14, 2024

Describe your changes

Add a /certificates/photos endpoint for getting a (voter authority) certificate photo. I don't necessarily agree with the naming conventions but I'm keeping it similar to the existing endpoint for AED photos to make the frontend easy.

Issue ticket number and link

https://dluhcdigital.atlassian.net/browse/EROPSPT-390

Checklist before requesting a review

  • I double checked that ACs on the ticket are met by this code update
  • I have added testing steps to the ticket
  • I have updated the relevant yml versions
  • I have formatted the code
  • I have added tests to new code and updated existing tests where needed
  • I have added any corresponding changes to the UI portal

Additional notes

Copy link
Contributor

@aleyipsoftwire aleyipsoftwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kirstenland kirstenland merged commit a9d4e2b into main Nov 15, 2024
1 check passed
@kirstenland kirstenland deleted the EROPSPT-390 branch November 15, 2024 14:04
aleyipsoftwire pushed a commit that referenced this pull request Nov 22, 2024
* EROPSPT-390: Add endpoint for VAC photos

* EROPSPT-390: Add VAC photo urls to summary responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants