FS-3797 #206

robk-dluhc · 2023-11-29T15:43:16Z

Correct workflow order.

Unit tests and other appropriate tests added or updated
README and other documentation has been updated / added (if needed)
Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

.github/workflows/copilot_deploy.yml

aaronwilliamsv1

LGTM

aaronwilliamsv1

Update LGTM too

robk-dluhc added 2 commits November 29, 2023 15:32

FS-3797 Workflow changes following review

a1609e8

Correct order

5e5745e

robk-dluhc had a problem deploying to dev November 29, 2023 15:52 — with GitHub Actions Error

Remove matrix completely

f612dd1

robk-dluhc temporarily deployed to Dev November 29, 2023 15:54 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 29, 2023 15:55 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to Dev November 29, 2023 15:55 — with GitHub Actions Inactive

aaronwilliamsv1 reviewed Nov 29, 2023

View reviewed changes

.github/workflows/copilot_deploy.yml Outdated Show resolved Hide resolved

robk-dluhc temporarily deployed to Dev November 29, 2023 16:06 — with GitHub Actions Inactive

Remove unneeded app_name

5f5acba

robk-dluhc temporarily deployed to Dev November 29, 2023 16:08 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 29, 2023 16:08 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to Dev November 29, 2023 16:09 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 29, 2023 16:09 — with GitHub Actions Inactive

Remove unneeded app_name

d8efd73

robk-dluhc temporarily deployed to Dev November 29, 2023 16:12 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 29, 2023 16:13 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 29, 2023 16:14 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 29, 2023 16:30 — with GitHub Actions Inactive

aaronwilliamsv1 previously approved these changes Nov 29, 2023

View reviewed changes

Test

45d48d6

robk-dluhc dismissed aaronwilliamsv1’s stale review via 45d48d6 November 29, 2023 16:51

robk-dluhc temporarily deployed to Dev November 29, 2023 16:51 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 29, 2023 16:52 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 29, 2023 17:03 — with GitHub Actions Inactive

aaronwilliamsv1 previously approved these changes Nov 29, 2023

View reviewed changes

robk-dluhc temporarily deployed to test November 29, 2023 17:22 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to Dev November 29, 2023 17:32 — with GitHub Actions Inactive

Wrong matrix

64886ef

robk-dluhc dismissed aaronwilliamsv1’s stale review via 64886ef November 30, 2023 07:39

robk-dluhc temporarily deployed to Dev November 30, 2023 07:39 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 30, 2023 07:40 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 30, 2023 07:41 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to Dev November 30, 2023 07:51 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to test November 30, 2023 07:56 — with GitHub Actions Inactive

robk-dluhc had a problem deploying to dev November 30, 2023 08:08 — with GitHub Actions Failure

Block concurrency on post-deploy testing

1e8f4a3

robk-dluhc temporarily deployed to Dev November 30, 2023 08:58 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 30, 2023 08:59 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 30, 2023 09:00 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to Dev November 30, 2023 09:10 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to test November 30, 2023 09:14 — with GitHub Actions Inactive

robk-dluhc had a problem deploying to dev November 30, 2023 09:26 — with GitHub Actions Failure

aaronwilliamsv1 approved these changes Nov 30, 2023

View reviewed changes

robk-dluhc merged commit ea9a235 into main Nov 30, 2023
26 of 29 checks passed

robk-dluhc deleted the FS-3797 branch November 30, 2023 11:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FS-3797 #206

FS-3797 #206

robk-dluhc commented Nov 29, 2023

aaronwilliamsv1 left a comment

aaronwilliamsv1 left a comment

FS-3797 #206

FS-3797 #206

Conversation

robk-dluhc commented Nov 29, 2023

aaronwilliamsv1 left a comment

Choose a reason for hiding this comment

aaronwilliamsv1 left a comment

Choose a reason for hiding this comment