Skip to content

Commit

Permalink
Merge branch 'main' into fix-unify-cycles
Browse files Browse the repository at this point in the history
  • Loading branch information
tomvanmele committed Apr 22, 2024
2 parents 0c3ebc0 + 5d89127 commit c9eb56d
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Changed and updated the `compas_view2` examples into `compas_viewer`.
* Changed `compas.scene.Scene` to inherent from `compas.datastructrues.Tree`.
* Changed `compas.scene.SceneObject` to inherent from `compas.datastructrues.TreeNode`.
* Changed `compas.geoemetry._core.predicates_3` bug fix in `is_coplanar` while loop when there are 4 points.
* Changed to implementation of `Mesh.unify_cycles` to use the corresponding function of `compas.topology.orientation`.
* Fixed bug in `compas.topology.orientation.unify_cycles`.
* Fixed bug in `Mesh.thickened`.
Expand Down
2 changes: 1 addition & 1 deletion src/compas/geometry/_core/predicates_3.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def is_coplanar(points, tol=None):

temp = points[:]

while True:
while len(temp) >= 3:
a = temp.pop(0)
b = temp.pop(0)
c = temp.pop(0)
Expand Down
13 changes: 13 additions & 0 deletions tests/compas/geometry/test_core_predicates_3.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
from compas.geometry import is_coplanar
import pytest


def test_is_coplanar():

# 4 points that are colinear:
points = [[0, 0, 0], [0, 1, 0], [0, 2, 0], [0, 4, 0]]

try:
is_coplanar(points)
except IndexError:
pytest.fail("is_coplanar raised an IndexError")

0 comments on commit c9eb56d

Please sign in to comment.