Skip to content

Commit

Permalink
Fix Mesh.face_circle
Browse files Browse the repository at this point in the history
  • Loading branch information
robin-oval committed Sep 11, 2024
1 parent 975dc97 commit e0dc716
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* Fixed args for `SceneObject` on Grasshopper `Draw` component.
* Replaced use of `Rhino.Geometry.VertexColors.SetColors` with a for loop and `SetColor` in `compas_ghpyton` since the former requires a `System.Array`.
* Fixed `Mesh.face_circle`.

### Removed

Expand Down
2 changes: 1 addition & 1 deletion src/compas/datastructures/mesh/mesh.py
Original file line number Diff line number Diff line change
Expand Up @@ -4542,7 +4542,7 @@ def face_circle(self, face):
from compas.geometry import bestfit_circle_numpy

point, normal, radius = bestfit_circle_numpy(self.face_coordinates(face))
return Circle((point, normal), radius)
return Circle.from_plane_and_radius(Plane(point, normal), radius)

def face_frame(self, face):
"""The frame of a face.
Expand Down

0 comments on commit e0dc716

Please sign in to comment.