Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a few bugs in Quaternion #1328

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Fixed a few bugs in Quaternion #1328

merged 2 commits into from
Apr 22, 2024

Conversation

gonzalocasas
Copy link
Member

@gonzalocasas gonzalocasas commented Apr 22, 2024

There were a few small bugs in the quaternion class implementation. (that i bumped into when trying to see if it would be possible to write a pure-python slerp implementation /cc @jf--- 😉 )

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@jf---
Copy link
Contributor

jf--- commented Apr 22, 2024

@gonzalocasas cool! The PR wrt slerp now is a pure Python implementation with a slerp method added to the quaternion class

Copy link
Member

@tomvanmele tomvanmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gonzalocasas gonzalocasas merged commit 9c1216c into main Apr 22, 2024
12 checks passed
@gonzalocasas gonzalocasas deleted the fix-quaternion branch April 22, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants