Modernise config #1330
Modernise config #1330
Conversation
|
only the first 3 commits are relevant. |
pyproject.toml
Outdated
| line-length = 179 | ||
|
|
||
| [tool.ruff] | ||
| line-length = 179 |
There was a problem hiding this comment.
I wouldn't change the max line length together with this PR. It makes this PR impossible to review because the entire code base has been reformatted. I assume that if it's kept at 120, the changes will be easier to see.
There was a problem hiding this comment.
it is not so much because of the line length (this only changed a few files), but mostly because the new config activates import sorting on non __init__.py files
tomvanmele
force-pushed
the
modernise-config
branch
from
eae9ef2
to
50c4755
Compare
tomvanmele
force-pushed
the
modernise-config
branch
from
4484fa6
to
dddd5e1
Compare
|
@gonzalocasas should be reviewable now... |
| from compas_invocations import docs | ||
| from compas_invocations import style | ||
| from compas_invocations import tests | ||
| from compas_invocations2 import build |
There was a problem hiding this comment.
Oh, I didn't know we had a compas_invocations2 :)
requirements-dev.txt
Outdated
| black >=22.12.0 | ||
| bump-my-version | ||
| compas_invocations2 | ||
| compas_notebook |
There was a problem hiding this comment.
Is the dependency on compas_notebook intentional or leftover?
There was a problem hiding this comment.
leftover. will remove it...
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.