Update/rhino point conversion #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalocasas
requested changes
Apr 29, 2024
CHANGELOG.md
Outdated
| @@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| * Changed use of `compas.geometry.allclose` to `compas.tolerance.TOL.is_allclose`. | |||
| * Changed use of `compas.geometry.close` to `compas.tolerance.TOL.is_close`. | |||
| * Changed imports of itertools to `compas.itertools` instead of `compas.utilities`. | |||
| * Updated `compas_rhino.conversions.point_to_compas` to allow for `compas.geometry.Point` as input. | |||
There was a problem hiding this comment.
Do you mean to allow for `Rhino.Geometry.Point` as input.?
Comment on lines
113
to
118
| if isinstance(point, Rhino.Geometry.Point3d): | ||
| return Point(point.X, point.Y, point.Z) | ||
| elif isinstance(point, Rhino.Geometry.Point): | ||
| return Point(point.Location.X, point.Location.Y, point.Location.Z) | ||
| else: | ||
| raise TypeError("Expected Rhino.Geometry.Point3d or Rhino.Geometry.Point., got: {}".format(type(point))) |
There was a problem hiding this comment.
Instead of relying on type checking, I would rely on "feature checking". Something like this maybe?
Suggested change
| if isinstance(point, Rhino.Geometry.Point3d): | |
| return Point(point.X, point.Y, point.Z) | |
| elif isinstance(point, Rhino.Geometry.Point): | |
| return Point(point.Location.X, point.Location.Y, point.Location.Z) | |
| else: | |
| raise TypeError("Expected Rhino.Geometry.Point3d or Rhino.Geometry.Point., got: {}".format(type(point))) | |
| if hasattr(point, "X"): | |
| return Point(point.X, point.Y, point.Z) | |
| elif hasattr(point, "Location"): | |
| return Point(point.Location.X, point.Location.Y, point.Location.Z) | |
| else: | |
| raise TypeError("Unexpected point type, got: {}".format(type(point))) |
Or maybe not even that, maybe just try..except idiom:
try:
return Point(point.X, point.Y, point.Z)
except MissingMemberException:
try:
return Point(point.Location.X, point.Location.Y, point.Location.Z)
except MissingMemberException:
raise TypeError("Unexpected point type, got: {}".format(type(point)))There was a problem hiding this comment.
Sounds good! using try except now
gonzalocasas
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for #1343