Bugfix/bbox #1352
Merged
Bugfix/bbox #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvanmele
reviewed
May 7, 2024
tests/compas/geometry/test_bbox.py
Outdated
| return compas.json_load(os.path.join(HERE, "fixtures", "bbox_points_00.json")) | ||
|
|
||
| @pytest.mark.parametrize( | ||
| "points, expected", |
There was a problem hiding this comment.
i think that if you remove the space here, ipy will stop complaining...
"points,expected"
There was a problem hiding this comment.
ah ok... thank you will try this one
There was a problem hiding this comment.
hmmm still does not like it.. i guess ipy pytest does not know to use request.getfixturevalue
tomvanmele
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
compas.geometry.bbox_numpy.minimum_volume_boxto avoidnumpy.linalg.LinAlgErrorand added some test points.What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.