Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update discretisations #1365

Merged
merged 19 commits into from
Jun 5, 2024
Merged

Update discretisations #1365

merged 19 commits into from
Jun 5, 2024

Conversation

tomvanmele
Copy link
Member

@tomvanmele tomvanmele commented Jun 3, 2024

This makes discretisation of shapes consistent and more reliable and robust. It furthermore greatly simplifies using discretisations in visualisation contexts such as compas_viewer and compas_notebook, and improves performance of the creation of buffer geometry. It also reduces overhead by minimising the number of discretisation components that have to be recomputed when the resolution of the discretisation is unchanged.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Contributor

@Licini Licini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@tomvanmele tomvanmele merged commit 40cf2c0 into main Jun 5, 2024
15 checks passed
@tomvanmele tomvanmele deleted the update-discretisations branch June 11, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants