-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Scene Object implementation consistency and Scene serialisation #1367
Conversation
looking great, just curious why did you choose to complete drop the scene serialization test for IPY? |
black, ruff, ... always add a comma after the last parameter of this problem is only triggered in this particular test... |
ok that's annoying 😅 |
@tomvanmele Is this one ready? I realized #1353 needs to go after this because there are a lot of overlaps |
yes i think it is ready |
self.vertexgroup = vertexgroup | ||
self.edgegroup = edgegroup | ||
self.facegroup = facegroup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have to be this PR, but one thing to consider would be also allow to serialise the context specific parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas.datastructures.Mesh
.