Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scene Object implementation consistency and Scene serialisation #1367

Merged
merged 29 commits into from
Jun 7, 2024

Conversation

tomvanmele
Copy link
Member

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@Licini
Copy link
Contributor

Licini commented Jun 6, 2024

looking great, just curious why did you choose to complete drop the scene serialization test for IPY?

@tomvanmele
Copy link
Member Author

looking great, just curious why did you choose to complete drop the scene serialization test for IPY?

black, ruff, ... always add a comma after the last parameter of VolMesh.__init__ (and any other class with a long parameter list). you can't turn this off, and IronPython can't deal with it.

this problem is only triggered in this particular test...

@Licini
Copy link
Contributor

Licini commented Jun 7, 2024

looking great, just curious why did you choose to complete drop the scene serialization test for IPY?

black, ruff, ... always add a comma after the last parameter of VolMesh.__init__ (and any other class with a long parameter list). you can't turn this off, and IronPython can't deal with it.

this problem is only triggered in this particular test...

ok that's annoying 😅

@Licini
Copy link
Contributor

Licini commented Jun 7, 2024

@tomvanmele Is this one ready? I realized #1353 needs to go after this because there are a lot of overlaps

@tomvanmele
Copy link
Member Author

yes i think it is ready

Comment on lines +56 to +58
self.vertexgroup = vertexgroup
self.edgegroup = edgegroup
self.facegroup = facegroup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have to be this PR, but one thing to consider would be also allow to serialise the context specific parameters.

Copy link
Contributor

@Licini Licini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomvanmele tomvanmele merged commit 10a8ee1 into main Jun 7, 2024
9 of 10 checks passed
@tomvanmele tomvanmele deleted the fix-scene-consistency-and-serialisation branch June 11, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants