Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in ghpython draw_mesh where an System.Array was expected #1382

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

tetov
Copy link
Contributor

@tetov tetov commented Aug 7, 2024

What type of change is this?

  • Bug fix in a backwards-compatible manner.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@tetov
Copy link
Contributor Author

tetov commented Aug 7, 2024

SetColor with two arguments defaults to an overload that expects MeshFace, hence the four argument version.

I can't manage to display vertex colors in Rhino/Grasshopper though...

@tomvanmele
Copy link
Member

@gonzalocasas @chenkasirer i can't provide reliable feedback when it comes to GHPython...

Copy link
Member

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenkasirer
Copy link
Member

@tetov thanks for fixing this.
What do you mean you can't manage to display vertex colors though?

@gonzalocasas
Copy link
Member

Nice! 👏
Can we merge?

@tomvanmele
Copy link
Member

@gonzalocasas entirely up to you...

@gonzalocasas gonzalocasas merged commit 9b617a1 into compas-dev:main Sep 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants