compas_rhino.uninstall updated for ipy rhino8 #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetov
force-pushed
the
rhino_8_uninstall_update
branch
from
5961732
to
4406396
Compare
tomvanmele
reviewed
Aug 27, 2024
Comment on lines
+43
to
+49
| if version == "8.0": | ||
| # In Rhino 8 there is no scripts folder | ||
| installation_path = compas_rhino._get_default_rhino_ironpython_sitepackages_path(version) | ||
| else: | ||
| # We install COMPAS packages in the scripts folder | ||
| # instead of directly as IPy module. | ||
| installation_path = compas_rhino._get_rhino_scripts_path(version) |
There was a problem hiding this comment.
the goal of uninstalling is to remove all traces of packages, so perhaps we should try removing them from all possible locations...
|
@tetov can you add an entry in the CHANGELOG? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated uninstall to match install, like here: cbe33b4
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.I added a line to theCHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).I added new functions/classes and made them available on a second-level import, e.g.compas.datastructures.Mesh.I have added tests that prove my fix is effective or that my feature works.I have added necessary documentation (if appropriate)