Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mesh.face_circle #1390

Merged
merged 1 commit into from
Sep 11, 2024
+2 −1
Merged

Fix Mesh.face_circle #1390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* Fixed args for `SceneObject` on Grasshopper `Draw` component.
* Replaced use of `Rhino.Geometry.VertexColors.SetColors` with a for loop and `SetColor` in `compas_ghpyton` since the former requires a `System.Array`.
* Fixed `Mesh.face_circle`.

### Removed

Expand Down
2 changes: 1 addition & 1 deletion src/compas/datastructures/mesh/mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4542,7 +4542,7 @@ def face_circle(self, face):
from compas.geometry import bestfit_circle_numpy

point, normal, radius = bestfit_circle_numpy(self.face_coordinates(face))
return Circle((point, normal), radius)
return Circle.from_plane_and_radius(Plane(point, normal), radius)

def face_frame(self, face):
"""The frame of a face.
Expand Down
Loading